Skip to content

refactor: Move upload/delete transcript into video_config service #37657

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
kdmccormick wants to merge 4 commits into
base: master
Choose a base branch
from
Open

refactor: Move upload/delete transcript into video_config service #37657

kdmccormick wants to merge 4 commits into from
+200 −133

Conversation

@kdmccormick
Copy link
Member

@kdmccormick kdmccormick commented Nov 19, 2025

Description

This moves edx-platform-specific logic out of the VideoBlock, in preparation for the VideoBlock extraction:
#36282

Testing instructions

Go to studio, and in a course, add a transcript, and delete it.
Do the same in a v2 library.

@kdmccormick kdmccormick changed the title refactor: Move upload/delete transcript int video_config service refactor: Move upload/delete transcript into video_config service Nov 19, 2025
@kdmccormick kdmccormick force-pushed the kdmccormick/upload-delete-transcript branch 3 times, most recently from b27c671 to 097c430 Compare November 20, 2025 04:45
@kdmccormick kdmccormick marked this pull request as ready for review November 20, 2025 04:45
@kdmccormick kdmccormick mentioned this pull request Nov 20, 2025
Draft
@kdmccormick kdmccormick force-pushed the kdmccormick/upload-delete-transcript branch from 696e7df to a738d26 Compare November 20, 2025 16:42
@farhan farhan added the create-sandbox open-craft-grove should create a sandbox environment from this PR label Nov 24, 2025
@open-craft-grove
Copy link

open-craft-grove commented Nov 24, 2025

Sandbox deployment failed 💥
Please check the settings and requirements.
Retry deployment by pushing a new commit or updating the requirements/settings in the pull request's description.
📜 Failure Logs
ℹ️ Grove Config, Tutor Config, Tutor Requirements

@open-craft-grove
Copy link

open-craft-grove commented Nov 24, 2025

Sandbox deployment failed 💥
Please check the settings and requirements.
Retry deployment by pushing a new commit or updating the requirements/settings in the pull request's description.
📜 Failure Logs
ℹ️ Grove Config, Tutor Config, Tutor Requirements

@open-craft-grove
Copy link

open-craft-grove commented Nov 24, 2025

Sandbox deployment successful 🚀
🎓 LMS
📝 Studio
ℹ️ Grove Config, Tutor Config, Tutor Requirements

@farhan
Copy link
Contributor

farhan commented Nov 25, 2025 •
edited
Loading

Transcripts are not uploading in the content library

Screenshot 2025-11-25 at 10 57 59 AM

farhan
farhan requested changes Nov 25, 2025
View reviewed changes
openedx/core/djangoapps/video_config/services.py
if is_library:
# Save transcript as static asset in Learning Core if is a library component
filename = f'transcript-{new_language_code}.srt'
add_library_block_static_asset_file(video_block.usage_key, f"static/{filename}", content)
Copy link
Contributor

@farhan farhan Nov 24, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We are appending static and passing in the param here unlike we are setting it in the transcripts field of video block in old code here

Which will possibly not update the field while saving here

farhan
farhan reviewed Nov 25, 2025
View reviewed changes
@farhan farhan requested a review from feanil November 26, 2025 11:49
farhan
farhan reviewed Nov 26, 2025
View reviewed changes
@farhan farhan force-pushed the kdmccormick/upload-delete-transcript branch from d633e66 to 0e56827 Compare December 2, 2025 15:15
@open-craft-grove
Copy link

open-craft-grove commented Dec 3, 2025

Sandbox deployment successful 🚀
🎓 LMS
📝 Studio
ℹ️ Grove Config, Tutor Config, Tutor Requirements

@open-craft-grove
Copy link

open-craft-grove commented Dec 3, 2025

Sandbox deployment successful 🚀
🎓 LMS
📝 Studio
ℹ️ Grove Config, Tutor Config, Tutor Requirements

@farhan farhan force-pushed the kdmccormick/upload-delete-transcript branch from 0e56827 to c4561ed Compare December 3, 2025 12:42
@open-craft-grove
Copy link

open-craft-grove commented Dec 3, 2025

Sandbox deployment successful 🚀
🎓 LMS
📝 Studio
ℹ️ Grove Config, Tutor Config, Tutor Requirements

@kdmccormick @farhan
refactor: Move upload/delete transcript int video_config service
8bff04b 
This moves edx-platform-specific logic out of the VideoBlock,
in preparation for the VideoBlock extraction:
openedx#36282
@kdmccormick @farhan
fix: respond with new edx_video_id if created by transcript upload
886a2ed
@farhan farhan force-pushed the kdmccormick/upload-delete-transcript branch from c4561ed to 886a2ed Compare December 5, 2025 13:08
@open-craft-grove
Copy link

open-craft-grove commented Dec 5, 2025

Sandbox deployment failed 💥
Please check the settings and requirements.
Retry deployment by pushing a new commit or updating the requirements/settings in the pull request's description.
📜 Failure Logs
ℹ️ Grove Config, Tutor Config, Tutor Requirements

@farhan farhan force-pushed the kdmccormick/upload-delete-transcript branch from d968f53 to 6412637 Compare December 5, 2025 14:55
@open-craft-grove
Copy link

open-craft-grove commented Dec 5, 2025

Sandbox deployment successful 🚀
🎓 LMS
📝 Studio
ℹ️ Grove Config, Tutor Config, Tutor Requirements

@open-craft-grove
Copy link

open-craft-grove commented Dec 5, 2025

Sandbox deployment successful 🚀
🎓 LMS
📝 Studio
ℹ️ Grove Config, Tutor Config, Tutor Requirements

@farhan
fix: Ignore following broken contract
6f7891d 
Low-level apps should not depend on high-level apps
@farhan farhan force-pushed the kdmccormick/upload-delete-transcript branch from 6c93bd4 to 6f7891d Compare December 10, 2025 08:44
@farhan
Copy link
Contributor

farhan commented Dec 10, 2025

Transcripts are not uploading in the content library

Screenshot 2025-11-25 at 10 57 59 AM

Issue has been tested and its fixed now.

@farhan
Copy link
Contributor

farhan commented Dec 10, 2025

Following testing is done on the sandbox.
Go to studio, and in a course, add a transcript, and delete it.
Do the same in a v2 library.

@open-craft-grove
Copy link

open-craft-grove commented Dec 10, 2025

Sandbox deployment successful 🚀
🎓 LMS
📝 Studio
ℹ️ Grove Config, Tutor Config, Tutor Requirements

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@farhan farhan farhan requested changes

@irtazaakram irtazaakram Awaiting requested review from irtazaakram irtazaakram is a code owner

@salman2013 salman2013 Awaiting requested review from salman2013 salman2013 is a code owner

@feanil feanil Awaiting requested review from feanil

Requested changes must be addressed to merge this pull request.

Assignees

No one assigned

Labels

create-sandbox open-craft-grove should create a sandbox environment from this PR

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@kdmccormick @open-craft-grove @farhan